fix: a nit

celestiaorg · Jan 7, 2025 · b81bf31 · b81bf31
1 parent 1a3bbcc
commit b81bf31
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/e2e/suite.go b/e2e/suite.go
@@ -23,6 +23,10 @@ const (
 
 	nginxImage       = "docker.io/nginx:latest"
 	nginxVolumeOwner = 0
+
+	envK8sHost      = "K8S_HOST"
+	envK8sCACert    = "K8S_CA_CERT"
+	envK8sAuthToken = "K8S_AUTH_TOKEN"
 )
 
 type Suite struct {
@@ -97,16 +101,16 @@ func (s *Suite) RetryOperation(operation func() error, maxRetries int) error {
 }
 
 func (s *Suite) K8sDefaultOptions() []k8s.Option {
-	if os.Getenv("K8S_AUTH_TOKEN") == "" {
-		s.T().Log("K8S_AUTH_TOKEN is not set, using default cluster config from ~/.kube/config")
+	if os.Getenv(envK8sAuthToken) == "" || os.Getenv(envK8sCACert) == "" || os.Getenv(envK8sHost) == "" {
+		s.T().Logf("%s, %s and/or %s are not set, using default cluster config from ~/.kube/config", envK8sAuthToken, envK8sCACert, envK8sHost)
 		return nil
 	}
 
 	return []k8s.Option{
 		k8s.WithAuthToken(
-			os.Getenv("K8S_HOST"),
-			os.Getenv("K8S_CA_CERT"),
-			os.Getenv("K8S_AUTH_TOKEN"),
+			os.Getenv(envK8sHost),
+			os.Getenv(envK8sCACert),
+			os.Getenv(envK8sAuthToken),
 		),
 	}
 }
diff --git a/pkg/k8s/namespace.go b/pkg/k8s/namespace.go
@@ -2,7 +2,6 @@ package k8s
 
 import (
 	"context"
-	"fmt"
 
 	corev1 "k8s.io/api/core/v1"
 	apierrs "k8s.io/apimachinery/pkg/api/errors"
@@ -26,7 +25,6 @@ func (c *Client) CreateNamespace(ctx context.Context, name string) error {
 	_, err := c.clientset.CoreV1().Namespaces().Create(ctx, namespace, metav1.CreateOptions{})
 	if err != nil {
 		if !apierrs.IsAlreadyExists(err) {
-			fmt.Printf("err: %v\n", err)
 			return err
 		}
 		c.logger.WithField("name", name).Debug("namespace already exists, continuing")