Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: cache imported roots for EDS #84

Open
Wondertan opened this issue Apr 27, 2022 · 0 comments
Open

api: cache imported roots for EDS #84

Wondertan opened this issue Apr 27, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Wondertan
Copy link
Member

Currently, the EDS has a stateless design, meaning that each operation(repairing) with it recomputes and verifies the integrity of the data according to the given roots. Instead, we can cache the roots during import and stick to those during the whole lifespan of an EDS instance. This is especially useful for users who try to repair the same EDS multiple times over the same roots.

Proposed Changes:

  • Remove roots params from Repair and cache them on EDS
  • Don't reset roots in setCell together with api: Public SetCell  #83. Resetting was initially introduced to prevent users from breaking eds when using public setCell(which was actually never made). However, api: Public SetCell  #83 proposes another solution for proper encapsulation(setting only nil cell) which makes resetting obsolete.
@Wondertan Wondertan added the enhancement New feature or request label Apr 27, 2022
@adlerjohn adlerjohn moved this to TODO in Celestia Node Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: TODO
Development

No branches or pull requests

1 participant