chore: upgrade to Go 1.21 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 7 7
Lines 793 793
=======================================
Hits 641 641
Misses 110 110
Partials 42 42 |
https://github.com/golangci/golangci-lint/releases/tag/v1.54.0 claims support for Go 1.21
cmwaters
approved these changes
Aug 11, 2023
evan-forbes
approved these changes
Aug 11, 2023
rootulp
added a commit
that referenced
this pull request
Aug 11, 2023
Closes #161 Blocked on #263 ## Testing The `BenchmarkEDSRoots` benchmark behaves similarly before and after this PR. Since it is computing roots, I assume the SHA256 operations for minio/sha256-simd and Go 1.21's crypto/sha256 perform similarly. ### Before ``` Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkEDSRoots$ github.com/celestiaorg/rsmt2d goos: darwin goarch: arm64 pkg: github.com/celestiaorg/rsmt2d BenchmarkEDSRoots/32x32x512_ODS-10 1063 1169687 ns/op 1791189 B/op 34052 allocs/op BenchmarkEDSRoots/64x64x512_ODS-10 392 3056992 ns/op 6203578 B/op 133636 allocs/op BenchmarkEDSRoots/128x128x512_ODS-10 100 10686539 ns/op 26235561 B/op 530437 allocs/op BenchmarkEDSRoots/256x256x512_ODS-10 31 42617637 ns/op 106996448 B/op 2110469 allocs/op BenchmarkEDSRoots/512x512x512_ODS-10 7 158435357 ns/op 490824795 B/op 8419427 allocs/op PASS ok github.com/celestiaorg/rsmt2d 9.528s ``` ### After ``` Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkEDSRoots$ github.com/celestiaorg/rsmt2d goos: darwin goarch: arm64 pkg: github.com/celestiaorg/rsmt2d BenchmarkEDSRoots/32x32x512_ODS-10 1010 1168943 ns/op 1793211 B/op 34052 allocs/op BenchmarkEDSRoots/64x64x512_ODS-10 381 3175877 ns/op 6207691 B/op 133636 allocs/op BenchmarkEDSRoots/128x128x512_ODS-10 100 10775309 ns/op 26243828 B/op 530438 allocs/op BenchmarkEDSRoots/256x256x512_ODS-10 32 69096212 ns/op 107013057 B/op 2110472 allocs/op BenchmarkEDSRoots/512x512x512_ODS-10 7 158312988 ns/op 490854710 B/op 8419386 allocs/op PASS ok github.com/celestiaorg/rsmt2d 9.516s ```
0xchainlover
pushed a commit
to celestia-org/rsmt2d
that referenced
this pull request
Aug 1, 2024
Closes celestiaorg/rsmt2d#161 Blocked on celestiaorg/rsmt2d#263 ## Testing The `BenchmarkEDSRoots` benchmark behaves similarly before and after this PR. Since it is computing roots, I assume the SHA256 operations for minio/sha256-simd and Go 1.21's crypto/sha256 perform similarly. ### Before ``` Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkEDSRoots$ github.com/celestiaorg/rsmt2d goos: darwin goarch: arm64 pkg: github.com/celestiaorg/rsmt2d BenchmarkEDSRoots/32x32x512_ODS-10 1063 1169687 ns/op 1791189 B/op 34052 allocs/op BenchmarkEDSRoots/64x64x512_ODS-10 392 3056992 ns/op 6203578 B/op 133636 allocs/op BenchmarkEDSRoots/128x128x512_ODS-10 100 10686539 ns/op 26235561 B/op 530437 allocs/op BenchmarkEDSRoots/256x256x512_ODS-10 31 42617637 ns/op 106996448 B/op 2110469 allocs/op BenchmarkEDSRoots/512x512x512_ODS-10 7 158435357 ns/op 490824795 B/op 8419427 allocs/op PASS ok github.com/celestiaorg/rsmt2d 9.528s ``` ### After ``` Running tool: /usr/local/go/bin/go test -benchmem -run=^$ -bench ^BenchmarkEDSRoots$ github.com/celestiaorg/rsmt2d goos: darwin goarch: arm64 pkg: github.com/celestiaorg/rsmt2d BenchmarkEDSRoots/32x32x512_ODS-10 1010 1168943 ns/op 1793211 B/op 34052 allocs/op BenchmarkEDSRoots/64x64x512_ODS-10 381 3175877 ns/op 6207691 B/op 133636 allocs/op BenchmarkEDSRoots/128x128x512_ODS-10 100 10775309 ns/op 26243828 B/op 530438 allocs/op BenchmarkEDSRoots/256x256x512_ODS-10 32 69096212 ns/op 107013057 B/op 2110472 allocs/op BenchmarkEDSRoots/512x512x512_ODS-10 7 158312988 ns/op 490854710 B/op 8419386 allocs/op PASS ok github.com/celestiaorg/rsmt2d 9.516s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #161