fix: verify encoding of shares in case when axis is fully reconstructed from orthogonal

extendeddatacrossword.go

@@ -138,10 +138,7 @@
 
 	// Prepare shares
 	shares := make([][]byte, eds.width)
-	vectorData := eds.row(uint(r))
-	for c := 0; c < int(eds.width); c++ {
-		shares[c] = vectorData[c]
-	}
+	copy(shares, eds.row(uint(r)))
 
 	// Attempt rebuild the row
 	rebuiltShares, isDecoded, err := eds.rebuildShares(shares)
@@ -177,6 +174,10 @@
 				}
 				return false, false, err
 			}
+
+			if eds.verifyEncoding(col, r, rebuiltShares[c]) != nil {
+				return false, false, &ErrByzantineData{Col, uint(c), col}
+			}
 		}
 	}
 
@@ -211,10 +212,7 @@
 
 	// Prepare shares
 	shares := make([][]byte, eds.width)
-	vectorData := eds.col(uint(c))
-	for r := 0; r < int(eds.width); r++ {
-		shares[r] = vectorData[r]
-	}
+	copy(shares, eds.col(uint(c)))
 
 	// Attempt rebuild
 	rebuiltShares, isDecoded, err := eds.rebuildShares(shares)
@@ -250,6 +248,10 @@
 				}
 				return false, false, err
 			}
+
+			if eds.verifyEncoding(row, c, rebuiltShares[r]) != nil {
+				return false, false, &ErrByzantineData{Row, uint(r), row}
+			}
 		}
 	}
 
@@ -468,3 +470,23 @@
 	}
 	return tree.Root()
 }
+
+// verifyEncoding checks the Reed-Solomon encoding of the provided data.
+func (eds *ExtendedDataSquare) verifyEncoding(data [][]byte, rebuiltIndex int, rebuiltShare []byte) error {
+	data[rebuiltIndex] = rebuiltShare
+	half := len(data) / 2
+	original := data[:half]
+	parity, err := eds.codec.Encode(original)
+	if err != nil {
+		return err
+	}
+
+	for i := half; i < len(data); i++ {
+		if !bytes.Equal(data[i], parity[i-half]) {
+			data[rebuiltIndex] = nil
+			return errors.New("parity data does not match encoded data")
+		}
+	}
+
+	return nil
+}