refactor: use deepCopy for eds.Flattened() #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 80.89% 82.24% +1.34%
==========================================
Files 8 7 -1
Lines 869 614 -255
==========================================
- Hits 703 505 -198
+ Misses 119 66 -53
+ Partials 47 43 -4 ☔ View full report in Codecov by Sentry. |
Wondertan
approved these changes
Apr 10, 2024
rootulp
approved these changes
Apr 10, 2024
staheri14
approved these changes
Apr 10, 2024
| @@ -335,7 +335,7 @@ func (ds *dataSquare) SetCell(x uint, y uint, newShare []byte) error { | |||
|
|
|||
| // Flattened returns the concatenated rows of the data square. | |||
| func (ds *dataSquare) Flattened() [][]byte { | |||
| flattened := [][]byte(nil) | |||
| flattened := make([][]byte, 0, ds.width*ds.width) | |||
There was a problem hiding this comment.
[nit] For better readability, this portion of the code i.e., ds.width*ds.width could be converted to a func that calculates the number of shares in a flattened data square.
rootulp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protect returned shares by
Flattened()with deepcopy similar to other exported methods