Fix underpriced check for multi currency #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage from tests in coverage: 50.8% of statements across all listed packagescoverage: 63.4% of statements in consensus/istanbul coverage: 42.7% of statements in consensus/istanbul/announce coverage: 55.7% of statements in consensus/istanbul/backend coverage: 0.0% of statements in consensus/istanbul/backend/backendtest coverage: 24.3% of statements in consensus/istanbul/backend/internal/replica coverage: 65.3% of statements in consensus/istanbul/core coverage: 50.0% of statements in consensus/istanbul/db coverage: 0.0% of statements in consensus/istanbul/proxy coverage: 64.2% of statements in consensus/istanbul/uptime coverage: 51.8% of statements in consensus/istanbul/validator coverage: 79.2% of statements in consensus/istanbul/validator/random |
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2206 +/- ##
==========================================
+ Coverage 55.08% 55.12% +0.03%
==========================================
Files 683 683
Lines 114533 114559 +26
==========================================
+ Hits 63095 63149 +54
+ Misses 47555 47530 -25
+ Partials 3883 3880 -3 ☔ View full report in Codecov by Sentry. |
|
Could you add a test that would reproduce the issue? |
carterqw2
reviewed
Nov 24, 2023
carterqw2
reviewed
Nov 24, 2023
palango
reviewed
Nov 27, 2023
palango
reviewed
Nov 27, 2023
palango
reviewed
Nov 27, 2023
hbandura
force-pushed
the
hbandura/fix_underpriced
branch
from
c2bde49 to
3e3dc16
Compare
carterqw2
reviewed
Nov 29, 2023
hbandura
force-pushed
the
hbandura/fix_underpriced
branch
2 times, most recently
from
3c21dba to
f877faf
Compare
palango
reviewed
Jan 12, 2024
hbandura
force-pushed
the
hbandura/fix_underpriced
branch
from
f877faf to
259886b
Compare
carterqw2
suggested changes
Jan 17, 2024
carterqw2
reviewed
Jan 17, 2024
carterqw2
suggested changes
Jan 18, 2024
hbandura
force-pushed
the
hbandura/fix_underpriced
branch
from
26a4881 to
12abea2
Compare
carterqw2
approved these changes
Jan 22, 2024
hbandura
force-pushed
the
hbandura/fix_underpriced
branch
from
12abea2 to
130d5cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous underprice implementation would provoke different currency comparisons, erroneously calculate the underprice flag, and ignore basefee in underprice comparisons.