Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate token lists for testnet and mainnet #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sodofi
Copy link
Contributor

@sodofi sodofi commented Nov 4, 2024

Current implementation of the tokenlist includes tokens from both chainId 42220 and 44787.

This change splits the list into two different lists, one for each chainId.

This will maintain tokenlist best practice structure where each list is dedicated for a dedicated chainId.

Please review this issue before merging since changing celo.tokenlist.json can affect users calling the list as it is.

Copy link
Member

@aaronmgdr aaronmgdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should bump the version on the celo token list.json since items were changed. not sure if its a major since items were removed or a patch since it just fixed that they shouldnt have been there

@aaronmgdr
Copy link
Member

@sodofi were you going to make the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants