-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGP-131 #411
Merged
+61
−0
Merged
CGP-131 #411
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4232969
Update delegatee count
pahor167 357d620
Update CGPs/cgp-0127.md
martinvol 3ad8803
Update CGPs/cgp-0127.md
martinvol 6cc91e5
Update CGPs/cgp-0127.md
work-0xj4an e04c739
Update CGPs/cgp-0127.md
work-0xj4an 0fc7557
Change proposal name
martinvol c803cd4
renamed folder
martinvol 028ce45
removed to 128
martinvol 89ddec9
Merge branch 'main' into pahor/updateDelegateeCount
martinvol 42dc3da
Changed to #130
martinvol 88f136a
Merge branch 'pahor/updateDelegateeCount' of github.com:celo-org/gove…
martinvol b87bc7b
Merge branch 'main' into pahor/updateDelegateeCount
martinvol 0d85c5a
Now to 131, to the moon
martinvol e1b8f6f
Merge branch 'pahor/updateDelegateeCount' of github.com:celo-org/gove…
martinvol 1233ff7
Fix number
martinvol 9fd56ea
Fixed date
martinvol 54cbccc
Merge branch 'main' into pahor/updateDelegateeCount
0xzoz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
--- | ||
cgp: 131 | ||
title: Update maxDelegateesCount to Improve Governance Flexibility | ||
date-created: 2024-03-12 | ||
author: "Pavel Hornak (@pahor167)" | ||
status: DRAFT | ||
discussions-to: https://forum.celo.org/t/celo-protocol-upgrades-gingerbread-hard-fork-and-contracts-release-10/6612 | ||
governance-proposal-id: 170 | ||
date-executed: 2050-01-01 | ||
--- | ||
|
||
## Overview | ||
|
||
This proposal seeks to update the `maxDelegateesCount` in the Celo governance promess. By increasing the limit on the number of delegatees, we're aiming to enhance the flexibility of vote delegation. This change is designed to accommodate the varying needs of Celo holders, recognizing that some may prefer to entrust their voting power to multiple delegates who can actively participate in the governance process on their behalf. This adjustment is a step towards optimizing governance participation, ensuring that it can be as effective and inclusive as possible. | ||
|
||
## Proposed Changes | ||
|
||
1. *Update `maxDelegateesCount`* | ||
- Destination: LockedGold, [setMaxDelegateesCount](https://github.com/celo-org/celo-monorepo/blob/7a2d29e9ffdef6cf078254142e61f896994c8a8b/packages/protocol/contracts/governance/LockedGold.sol#L160) | ||
- Data: 10 | ||
- Value: 0 (NA) | ||
|
||
## Verification | ||
|
||
1. Confirm proposal steps: run `celocli governance:view --proposalID 170 -n https://forno.celo.org ` | ||
|
||
## Risks | ||
|
||
The primary adjustment involves managing a potentially increased number of delegatees, which could introduce complexities in vote management. However, this change is anticipated to align with the community's desire for more dynamic and accessible governance mechanisms. | ||
|
||
## Useful Links | ||
|
||
- [Celo Governance Documentation](https://docs.celo.org/celo-owner-guide/governance) | ||
- [Celo CLI Documentation](https://docs.celo.org/command-line-interface/introduction) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
[ | ||
{ | ||
"contract": "SortedOracles", | ||
"function": "setEquivalentToken", | ||
"args": [ | ||
"0x0e2a3e05bc9a16f5292a6170456a710cb89c6f72", | ||
"0x874069Fa1Eb16D44d622F2e0Ca25eeA172369bC1" | ||
], | ||
"value": "0" | ||
}, | ||
{ | ||
"contract": "FeeCurrencyWhitelist", | ||
"function": "addToken", | ||
"args": [ | ||
"0x0e2a3e05bc9a16f5292a6170456a710cb89c6f72" | ||
], | ||
"value": "0" | ||
} | ||
] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
[ | ||
{ | ||
"contract": "LockedGold", | ||
"function": "setMaxDelegateesCount", | ||
"args": ["10"], | ||
"value": "0" | ||
} | ||
] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the many new checks, people keep finding creative ways to submit invalid data. @martinvol if the status is draft, then the date-executed cannot be anything but empty, since it refers to the date that the proposal gets executed on chain. Whatever that date is, it's certainly not 2050-01-01
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making sure proposals shouldn't have formatting errors should be responsability of the editors, they approved and merged the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree!