Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TA-3148: Update NodeExportTransport and export/import logic to work with JSON files #186

Merged
merged 7 commits into from
Jul 19, 2024

Conversation

Buqeta
Copy link
Contributor

@Buqeta Buqeta commented Jul 17, 2024

Description

This PR updates the NodeExportTransport's configuration property to object instead of string. Along with this, the batch import/export logic was updated to work with JSON files. The same is true for diffing.

Other:

  • Created a replacer function which tells the JSON.stringify function how to stringify a Map, because it doesn't support Maps. This was causing problems when trying to stringify ManifestTransport's dependenciesByVersion property, because it's a Map.
  • Updated the tests to work with the new changes.

Checklist

  • I have self-reviewed this PR
  • I have tested the change and proved that it works in different scenarios
  • I have updated docs if needed

@Buqeta Buqeta requested review from GencBlakqoriP9 and a team as code owners July 17, 2024 14:58
LaberionAjvazi
LaberionAjvazi previously approved these changes Jul 18, 2024
promeris
promeris previously approved these changes Jul 18, 2024
ZgjimHaziri
ZgjimHaziri previously approved these changes Jul 18, 2024
tests/utls/config-utils.ts Outdated Show resolved Hide resolved
src/services/studio/studio.service.ts Outdated Show resolved Hide resolved
src/interfaces/package-export-transport.ts Show resolved Hide resolved
@Buqeta Buqeta merged commit 141ad70 into master Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants