-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TA-3148: Update NodeExportTransport and export/import logic to work with JSON files #186
Merged
Buqeta
merged 7 commits into
master
from
TA-3148-update-batch-export-transports-and-logic
Jul 19, 2024
Merged
TA-3148: Update NodeExportTransport and export/import logic to work with JSON files #186
Buqeta
merged 7 commits into
master
from
TA-3148-update-batch-export-transports-and-logic
Jul 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaberionAjvazi
previously approved these changes
Jul 18, 2024
promeris
previously approved these changes
Jul 18, 2024
ZgjimHaziri
previously approved these changes
Jul 18, 2024
ksalihu
reviewed
Jul 18, 2024
Buqeta
dismissed stale reviews from ZgjimHaziri, promeris, and LaberionAjvazi
via
July 18, 2024 15:36
70efc91
ksalihu
approved these changes
Jul 18, 2024
promeris
approved these changes
Jul 19, 2024
ZgjimHaziri
approved these changes
Jul 19, 2024
frkntrcnn
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
NodeExportTransport
'sconfiguration
property to object instead of string. Along with this, the batch import/export logic was updated to work with JSON files. The same is true for diffing.Other:
JSON.stringify
function how to stringify a Map, because it doesn't support Maps. This was causing problems when trying to stringifyManifestTransport
'sdependenciesByVersion
property, because it's a Map.Checklist