[EMA-4088 & EMA-4345]: Integrate Action Flow Import/Export functionality #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously `... import --dryRun true` `... --dryRun false` now `... import --dryRyn` `... import` So in case you specify it, the command will get it as true and in case you do not specify it, the command will get it as false (Same thing is applied to outputToJsonFile input field) [EMA-4088]
somehow adding a zip with entries using the `adm-zip` constructor differs from adding the zip entries using the `addFile` method If I use the constructor to create the zip, and then send that zip to the server I was receiving the error `invalid entry size (expected 2187395080 but got 158 bytes)` [EMA-4088]
[EMA-4088]
currently we were passing dryRun as true even if it was explicitly set as false [EMA-4088]
Shpat-Jashari
previously approved these changes
Aug 20, 2024
promeris
reviewed
Aug 22, 2024
There was a problem hiding this comment.
Can you also include unit tests for the changes? You can follow some examples we have already, and you can reach out to @LaberionAjvazi if you need any further support.
and move `metadata.jon` as a static variable [EMA-4345]
AlbinHoxha
previously approved these changes
Aug 23, 2024
[EMA-4345]
promeris
reviewed
Aug 23, 2024
[EMA-4088]
…export-analyze-functionality
[EMA-4088]
promeris
previously approved these changes
Aug 26, 2024
jetakasabaqi
previously approved these changes
Aug 26, 2024
Buqeta
reviewed
Aug 26, 2024
LaberionAjvazi
previously approved these changes
Aug 26, 2024
…export-analyze-functionality
jetmirhalili11
dismissed stale reviews from jetakasabaqi and promeris
via
81304e8
Buqeta
approved these changes
Aug 27, 2024
promeris
approved these changes
Aug 27, 2024
LaberionAjvazi
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the functionality of import/export of action flows
Three new commands introduced
analyze action-flows- returns the action-flow metadata and its dependencies for a packageexport action-flows- returns the action-flow configuration and its dependencies for a packageimport action-flows- imports action-flows on a packageChecklist