input: Fix crash when closing add controller dialog before search completes #1386
Conversation
| struct AsyncThreadData | ||
| { | ||
| std::atomic_bool discardResult = false; | ||
| std::mutex mutex; |
There was a problem hiding this comment.
Suggestion: Make the mutex a member variable of InputAPIAddWindow. Tracking it per-thread only unnecessarily complicates things and is error prone.
There was a problem hiding this comment.
Actually, this may then introduce a race condition where this is destroyed before the thread accesses it. Not sure, maybe there is a less fragile way to handle this in general.
There was a problem hiding this comment.
maybe there is a less fragile way to handle this in general.
Have a look at the latest commit. I switched to a jthread. I think I was reinventing the wheel.
EDIT: I just remembered that Apple Clang doesn't support std::jthread 😢
There was a problem hiding this comment.
I've reverted it. Not only because of the lack of macOS support but also because it has more theoretical race conditions than the mutex.
This reverts commit 9500000.
Fixes: #869