Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to finding wiimotes (again) #961

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

capitalistspz
Copy link
Contributor

@capitalistspz capitalistspz commented Sep 5, 2023

  • Clear m_wiimotes before finding new wiimotes
  • Use only paths for comparison (I'm pretty sure that it's impossible for multiple wiimotes to open at the same path)
  • Also remove a duplicate line from my last PR

Should fix #960

- Clear `m_wiimotes` before finding new wiimotes
- Use only paths for comparison
@capitalistspz
Copy link
Contributor Author

I'll just wait for some people to test this before marking as ready

@GNUGradyn
Copy link

@capitalistspz
Copy link
Contributor Author

it looks like the linux build failed https://github.com/cemu-project/Cemu/actions/runs/6111890994/job/16588126558?pr=961

Due to clang-12 being too old for one of the features I used

I'll change the code a little

@GNUGradyn
Copy link

This mostly works. I connected 2 wiimotes to my steam deck and launched the app image generated by this PR. It correctly mapped one of them as player 1 and the other as player 2. The indicators on the remotes matched the mapping in the emulator. However when I disconnected and reconnected player 2, the indicator now shows it's player 1. However, the remote is still correctly mapped to player 2.

tl;dr everything works as long as you ignore the player indicators when a controller is reconnected

@capitalistspz capitalistspz marked this pull request as ready for review September 13, 2023 18:57
@Exzap Exzap merged commit 323bdfa into cemu-project:main Sep 19, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with reconnecting wiimotes as of 99c5e43b586b69006263020ea20dcf69973fb8d3
3 participants