This repository has been archived by the owner on Jan 11, 2025. It is now read-only.
forked from osbuild/bootc-image-builder
-
Notifications
You must be signed in to change notification settings - Fork 1
[pull] main from osbuild:main #6
Open
pull
wants to merge
18
commits into
centos-workstation:main
Choose a base branch
from
osbuild:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves to the new "flat" squashfs rootfs image that is now available in the `images` library (c.f. osbuild/images#1105). This will ensures we are no longer using the previous "ext4" intermediate image that gave problems for big rootfses. Closes: #733
This commit adds the two most useful progress types (as of today) to the help string of `--progress`: plain and term. This should make the usage a bit more discoverable.
This commit adds the missing documentation for `--progress` in the README. Not having this lead to some confusion, e.g. in questions in #765 that a better README would have avoided. Hopefully this answers the questions :)
Previously an empty string in `--progress` meant to "auto-select". But that is not super intuitive so this commit makes it explicit using "auto". Thanks to Achilleas for the suggestion.
This commit renames the "plain" progress to "verbose" progress. The new name is closer to what the intention of the this progress is and easier for the users to understand. Thanks to Ondrej for the suggestion.
This comit tweak the new and very nice functionality of cmdVersion in the following way: - Rename to versionFromBuildInfo as it is no longer a "cmd*" (i.e. it no longer takes a cobra.Command) - Use switch/case as it's slightly more compact than if/else - Just build the string directly instead of using a list (slightly shorter) - Change "build_status: ok" to "build_tainted" with a boolean value to ensure this is easier to parse in yaml (and more descriptive as "status" is quite generic and may mean many things to people). - Extend the test_bib_version to test for the full strings prefixes in test_opts.
This commit adds `--verbose,-v` which will increase the verbosity of logrus and also switch the --progress to "verbose". This is addressing the feedback we got in #765 and a followup for #776 The new `-v` clashes unfortunately with cobras default for version, so there is no single dash flag for version anymore. Most unix tools (e.g. cp,rsync,mv,curl,ssh,tar) use "-v" for "--verbose" so IMHO we should follow suite. Unfortuantely there is no consistency in linux, e.g. git,gcc are counter examples where it means version). I would still go with -v for verbose as ssh,tar,curl are probably used more often to get verbose output.
This commit updates the documentation around the supported flags. It also switches on "bold" for a smaller subset of the important flags. Note that still not all flags are shows, some are documented below (like the `--aws-*`) and some (like --store, --rpmmd) require more context, i.e. explaining that they require calling podman with the right `--volume` mappings.
We recently hit the issue that bootc-image-builder is no longer releasing. It turns out we hit the limit of our integration tests. Increase this limit for now.
The NewAnacondaContainerInstaller renamed SquashfsCompression to RootfsCompression.
This commit adds a new `--use-librepo` switch that will enable librepo based downloading so that people can play with the new backend. But not turn it on by default yet.
This commit make the use of librepo part of the testcases and enables it for the problematic testcases like fedora and centos-10. Eventually we should switch entirely to librepo but there is a regression risk with secrets so for now make it optional.
Document `--use-librepo` in the README and encourage its usage in the default example. It should be fine for centos and this way we hopefully get more exposure and bugreport (if there are issues).
Listing syntax was mixed, causing a strange linebreak. Also adapts the order to match all other repos.
Bumps the go-deps group with 2 updates in the /bib directory: [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) and [github.com/osbuild/images](https://github.com/osbuild/images). Updates `github.com/aws/aws-sdk-go` from 1.55.5 to 1.55.6 - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG_PENDING.md) - [Commits](aws/aws-sdk-go@v1.55.5...v1.55.6) Updates `github.com/osbuild/images` from 0.109.1-0.20250117082457-97ca7c62eb09 to 0.111.0 - [Release notes](https://github.com/osbuild/images/releases) - [Commits](https://github.com/osbuild/images/commits/v0.111.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps - dependency-name: github.com/osbuild/images dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go-deps ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the go-deps group in /bib with 1 update: [github.com/cheggaaa/pb/v3](https://github.com/cheggaaa/pb). Updates `github.com/cheggaaa/pb/v3` from 3.1.5 to 3.1.6 - [Commits](cheggaaa/pb@v3.1.5...v3.1.6) --- updated-dependencies: - dependency-name: github.com/cheggaaa/pb/v3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go-deps ... Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )