Limit BUS grant cap per annum #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengy90
reviewed
Nov 22, 2024
| boiler_upgrade_funding_cap_gbp = ( | ||
| BOILER_UPGRADE_SCHEME_GRANT_CAP[year] / model_population_scale | ||
| ) | ||
| if ( |
There was a problem hiding this comment.
Is this assuming that if in a year we underspend, the underspent amount gets carried forward to future years? If so worth clarifying that in the comment.
Helps with reviewing that the code is trying to emulate that behaviour. Worth calling out the assumption too in the report..
There was a problem hiding this comment.
IDK how govt works, but in a corporate world if budget is underspent, it usually doesn't get carried forward!
There was a problem hiding this comment.
Yes, it get carried forward, I will add a clarifying comment :)
shengy90
previously approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.