do not always error out while checking for existence of resources #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit divided b/n where the handling should happen, like, err returned from the load function can't always be same as returned by api server. To be moved inside the function it needs to copied at a couple of places, pls review. |
nb-ohad
requested changes
Oct 6, 2024
Madhu-1
reviewed
Oct 7, 2024
nb-ohad
requested changes
Oct 15, 2024
| @@ -130,6 +131,10 @@ func (r *ClientProfileReconciler) Reconcile(ctx context.Context, req ctrl.Reques | |||
|
|
|||
| func (r *ClientProfileReconcile) reconcile() error { | |||
| if err := r.loadAndValidate(); err != nil { | |||
| if k8serrors.IsNotFound(err) && r.clientProfile.UID == "" { | |||
There was a problem hiding this comment.
@leelavg wouldn't it make more sense to investigate the error object to see the target of the not found error?
| @@ -226,6 +226,10 @@ func (r *DriverReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr | |||
| func (r *driverReconcile) reconcile() error { | |||
| // Load the driver desired state based on driver resource, operator config resource and default values. | |||
| if err := r.LoadAndValidateDesiredState(); err != nil { | |||
| if k8serrors.IsNotFound(err) && r.driver.UID == "" { | |||
controllers also get reconciles for deletion events and it may happen that resource at api server be deleted first before it being purged from cache and during that time if we error out the reconciliation will never be successful in standard conditions. Signed-off-by: Leela Venkaiah G <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controllers also get reconciles for deletion events and it may happen that resource at api server be deleted first before it being purged from cache and during that time if we error out the reconciliation will never be successful in standard conditions.
fixes: #78