feat: script to update the datastore on c1 and selectively run the migration #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
gvelez17
commented
Oct 15, 2024
This comment was marked as outdated.
This comment was marked as outdated.
gvelez17
commented
Oct 17, 2024
smrz2001
reviewed
Oct 18, 2024
Comment on lines
+34
to
+42
| - name: Find latest common snapshot | ||
| ansible.builtin.shell: | ||
| cmd: | | ||
| kubo_snaps="{{ kubo_snapshots.stdout_lines | join('\n') }}" | ||
| c1_snaps="{{ c1_snapshots.stdout_lines | join('\n') }}" | ||
| echo "$kubo_snaps" | grep -F "$(echo "$c1_snaps" | sed 's/migrationpool\/data-store@//')" | tail -n 1 | ||
| register: common_snapshot | ||
| failed_when: common_snapshot.rc != 0 or common_snapshot.stdout == "" | ||
| delegate_to: localhost |
There was a problem hiding this comment.
Should this look for the latest common migrated snapshot? We don't just want to find the latest common snapshot, we want to find the one we know for sure was migrated last. WDYT?
There was a problem hiding this comment.
no, i don't think so, i think we just want to bring over everything since the latest common
if we make holes we can fix them manually, we want this whole process done in the next day or so
There was a problem hiding this comment.
i think the main thing is to keep the files, and snapshots, and to have each filename labeled by date range so that the data is all available for reruns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script will
find the latest common snapshot between go-ipfs and c1 nodes
create a new snapshot on go-ipfs and send to c1 node
on c1 node, generate a list of modified blocks
run the migration on the list of modified blocks and track errors
the c1 migration logs are piped to a file and include checkpointing