Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 [security] Upgrade sinatra to version 2.2.4 #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Dec 18, 2022


🚨 Your current dependencies have known security vulnerabilities 🚨

This dependency update fixes known security vulnerabilities. Please see the details below and assess their impact carefully. We recommend to merge and deploy this as soon as possible!


Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ sinatra (2.0.8.1 → 2.2.4) · Repo · Changelog

Security Advisories 🚨

🚨 Sinatra vulnerable to Reflected File Download attack

An issue was discovered in Sinatra 2.0 before 2.2.3 and 3.0 before 3.0.4.
An application is vulnerable to a reflected file download (RFD) attack that
sets the Content-Disposition header of a response when the filename is
derived from user-supplied input.

🚨 sinatra does not validate expanded path matches

Sinatra before 2.2.0 does not validate that the expanded path matches
public_dir when serving static files.

Release Notes

2.2.3 (from changelog)

  • Fix: Escape filename in the Content-Disposition header. #1841 by Kunpei Sakai

  • Fix: fixed ReDoS for Rack::Protection::IPSpoofing. #1823 by @ooooooo-q

2.2.2 (from changelog)

  • Update mustermann dependency to version 2.

2.2.0 (from changelog)

  • Handle EOFError raised by Rack and return Bad Request 400 status. #1743 by tamazon

  • Update README.es.md with removal of Thin. #1630 by Espartaco Palma

  • Minor refactors in base.rb. #1640 by ceclinux

  • Fixed typos in german README.md. #1648 by Juri

  • Add escaping to the static 404 page. #1645 by Chris Gavin

  • Remove detect_rack_handler method. #1652 by ceclinux

  • Respect content type set in superclass before filter. Fixes #1647 #1649 by Jordan Owens

  • Update README.ja.md with removal of Thin. #1629 by Ryuichi KAWAMATA

  • Revert "Use prepend instead of include for helpers. #1662 by namusyaka

  • Various minor fixes to README.md. #1663 by Yanis Zafirópulos

  • Document when dump_errors is enabled. Fixes #1664 #1665 by Patrik Ragnarsson

  • Update README.pt-br.md. #1668 by Vitor Oliveira

  • Fix usage of inherited Sinatra::Base classes keyword arguments. Fixes #1669 #1670 by Cadu Ribeiro

  • Reduce RDoc generation time by not including every README. Fixes #1578 #1671 by Eloy Pérez

  • Add support for per form csrf tokens. Fixes #1616 #1653 by Jordan Owens

  • Update MAINTENANCE.md with the stable branch status. #1681 by Fredrik Rubensson

  • Validate expanded path matches public_dir when serving static files. #1683 by cji-stripe

  • Fix Delegator to pass keyword arguments for Ruby 3.0. #1684 by andrewtblake

  • Fix use with keyword arguments for Ruby 3.0. #1701 by Robin Wallin

  • Fix memory leaks for proc template. Fixes #1704 #1719 by Slevin

  • Remove unnecessary test_files from the gemspec. #1712 by Masataka Pocke Kuwabara

  • Add #select, #reject and #compact methods to Sinatra::IndifferentHash. #1711 by Olivier Bellone

CI

  • Use latest JRuby 9.2.16.0 on CI. #1682 by Olle Jonsson

  • Switch CI from travis to Github actions. #1691 by namusyaka

  • Skip the Slack action if secrets.SLACK_WEBHOOK is not set. #1705 by Robin Wallin

  • Small CI improvements. #1703 by Robin Wallin

  • Drop auto-generated boilerplate comments from CI configuration file. #1728 by Olle Jonsson

sinatra-contrib

  • Do not raise when key is an enumerable. #1619 by Ulysse Buonomo

Rack protection

  • Fix broken origin_whitelist option. Fixes #1641 #1642 by Takeshi YASHIRO

2.1.0 (from changelog)

  • Fix additional Ruby 2.7 keyword warnings #1586 by Stefan Sundin

  • Drop Ruby 2.2 support #1455 by Eloy Pérez

  • Add Rack::Protection::ReferrerPolicy #1291 by Stefan Sundin

  • Add default_content_type setting. Fixes #1238 #1239 by Mike Pastore

  • Allow set :<engine> in sinatra-namespace #1255 by Christian Höppner

  • Use prepend instead of include for helpers. Fixes #1213 #1214 by Mike Pastore

  • Fix issue with passed routes and provides Fixes #1095 #1606 by Mike Pastore, Jordan Owens

  • Add QuietLogger that excludes pathes from Rack::CommonLogger 1250 by Christoph Wagner

  • Sinatra::Contrib dependency updates. Fixes #1207 #1411 by Mike Pastore

  • Allow CSP to fallback to default-src. Fixes #1484 #1490 by Jordan Owens

  • Replace origin_whitelist with permitted_origins. Closes #1620 #1625 by rhymes

  • Use Rainbows instead of thin for async/stream features. Closes #1624 #1627 by Ryuichi KAWAMATA

  • Enable EscapedParams if passed via settings. Closes #1615 #1632 by Anders Bälter

  • Support for parameters in mime types. Fixes #1141 by John Hope

  • Handle null byte when serving static files #1574 by Kush Fanikiso

  • Improve development support and documentation and source code by Olle Jonsson, Pierre-Adrien Buisson, Shota Iguchi

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by more commits than we can show here.


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants