Alerter Credentials in config.yaml #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add caller_id on required_options on ServiceNowAlerter and remove comments from required_options Add required_credentials as global configuaration options Update username and password on ServiceNowAlerter auth Remove username and password from required fields on ServiceNowAlerter Add snow_password and snow_username as required fields and caller_id as optional Update copy of required_credentials in load_options function
dimiechatz
force-pushed
the
dchatzic_snow
branch
from
5064525 to
9edc1e2
Compare
added 7 commits
July 22, 2019 13:28
Add caller_id on required_options on ServiceNowAlerter and remove comments from required_options Add required_credentials as global configuaration options Update username and password on ServiceNowAlerter auth Remove username and password from required fields on ServiceNowAlerter Add snow_password and snow_username as required fields and caller_id as optional Update copy of required_credentials in load_options function
…into dchatzic_snow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications allow us to have a more generic service now alerter, with
required parameters the:
The rest are optional and can be define per purpose of usage.
Also the credentials can be used in config.yaml / inside the rule as whatever user prefers. If they are configured in both places then the definitions of the rule aelrter credential is kept for convenience with the original release