Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Commit

Permalink
Merge branch 'main' into UXPLATFORM-10398
Browse files Browse the repository at this point in the history
  • Loading branch information
adavijit authored May 14, 2024
2 parents 3a8521c + 9fe1737 commit 167a0cf
Show file tree
Hide file tree
Showing 64 changed files with 1,478 additions and 1,911 deletions.
2,619 changes: 956 additions & 1,663 deletions package-lock.json

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions packages/terra-abstract-modal/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

## Unreleased

## 3.50.0 - (May 14, 2024)

* Changed
* Changes to announce title of modal.

## 3.49.0 - (March 8, 2024)

* Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/terra-abstract-modal/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "terra-abstract-modal",
"version": "3.49.0",
"version": "3.50.0",
"description": "The abstract modal is a structural component that provides the ability to display portal'd content in a layer above the app.",
"author": "Cerner Corporation",
"repository": {
Expand Down
6 changes: 4 additions & 2 deletions packages/terra-abstract-modal/src/_ModalContent.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ const ModalContent = forwardRef((props, ref) => {
// Delete the closePortal prop that comes from react-portal.
delete customProps.closePortal;
delete customProps.fallbackFocus;
const beginLabelId = ariaLabel === 'Modal' ? 'Terra.AbstractModal.BeginModalDialog' : 'Terra.AbstractModal.BeginModalDialogTitle';
const endLabelId = ariaLabel === 'Modal' ? 'Terra.AbstractModal.EndModalDialog' : 'Terra.AbstractModal.EndModalDialogTitle';

const modalContent = (
<div
Expand All @@ -156,7 +158,7 @@ const ModalContent = forwardRef((props, ref) => {
>
<div className={modalContainerClassName} ref={setModalFocusElementRef} data-terra-abstract-modal-begin tabIndex="-1">
{(!isCalledFromNotificationDialog) && (
<FormattedMessage id="Terra.AbstractModal.BeginModalDialog">
<FormattedMessage id={beginLabelId} values={{ title: ariaLabel }}>
{text => {
// In the latest version of react-intl this param is an array, when previous versions it was a string.
let useText = text;
Expand All @@ -171,7 +173,7 @@ const ModalContent = forwardRef((props, ref) => {
)}
{children}
{(!isCalledFromNotificationDialog) && (
<FormattedMessage id="Terra.AbstractModal.EndModalDialog">
<FormattedMessage id={endLabelId} values={{ title: ariaLabel }}>
{text => {
// In the latest version of react-intl this param is an array, when previous versions it was a string.
let useText = text;
Expand Down
Loading

0 comments on commit 167a0cf

Please sign in to comment.