[terra-table] Table single row select (#1901)

cerner · Nov 21, 2023 · c2eadb6 · c2eadb6
1 parent 5847800
commit c2eadb6
Show file tree

Hide file tree

Showing 33 changed files with 412 additions and 184 deletions.
diff --git a/packages/terra-data-grid/CHANGELOG.md b/packages/terra-data-grid/CHANGELOG.md
@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+Changed
+  * Updated Table component to use new `rowSelectionMode` prop instead of `hasSelectableRows`.
+
 ## 1.2.0 - (November 20, 2023)
 
 * Fixed

diff --git a/packages/terra-data-grid/src/DataGrid.jsx b/packages/terra-data-grid/src/DataGrid.jsx
@@ -571,7 +571,7 @@ const DataGrid = forwardRef((props, ref) => {
           onSectionSelect={onSectionSelect}
           onCellSelect={handleCellSelection}
           onRowSelectionHeaderSelect={handleRowSelectionHeaderSelect}
-          hasSelectableRows={hasSelectableRows}
+          rowSelectionMode={hasSelectableRows ? 'multiple' : undefined}
           hasVisibleColumnHeaders={hasVisibleColumnHeaders}
           isStriped
         />

diff --git a/packages/terra-data-grid/tests/jest/DataGrid.test.jsx b/packages/terra-data-grid/tests/jest/DataGrid.test.jsx
@@ -92,7 +92,7 @@ describe('DataGrid', () => {
   it('verifies the rows are created with the right props', () => {
     const verifyRow = (rowIndex, rowComponent, data, overflowColumns) => {
       expect(rowComponent.props.displayedColumns).toEqual(overflowColumns);
-      expect(rowComponent.props.hasRowSelection).toBe(false);
+      expect(rowComponent.props.rowSelectionMode).toBeUndefined();
       expect(rowComponent.key).toEqual(data.id);
       expect(rowComponent.props.onCellSelect).toBeDefined();
       expect(rowComponent.props.rowHeaderIndex).toEqual(0);

diff --git a/packages/terra-data-grid/tests/jest/__snapshots__/DataGrid.test.jsx.snap b/packages/terra-data-grid/tests/jest/__snapshots__/DataGrid.test.jsx.snap
@@ -5460,7 +5460,6 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
     <InjectIntl(Table)
       columnHeaderHeight="2.5rem"
       defaultColumnWidth={200}
-      hasSelectableRows={true}
       hasVisibleColumnHeaders={true}
       id="test-terra-data-grid-table"
       isActiveColumnResizing={false}
@@ -5496,6 +5495,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
       }
       rowHeaderIndex={0}
       rowHeight="2.5rem"
+      rowSelectionMode="multiple"
       rows={
         Array [
           Object {
@@ -5576,7 +5576,6 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
       <Table
         columnHeaderHeight="2.5rem"
         defaultColumnWidth={200}
-        hasSelectableRows={true}
         hasVisibleColumnHeaders={true}
         id="test-terra-data-grid-table"
         intl={
@@ -5639,6 +5638,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
         }
         rowHeaderIndex={0}
         rowHeight="2.5rem"
+        rowSelectionMode="multiple"
         rows={
           Array [
             Object {
@@ -6538,14 +6538,14 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                   },
                 ]
               }
-              hasRowSelection={true}
               id="00000000-0000-0000-0000-000000000000"
               isHidden={true}
               isTableStriped={true}
               key="00000000-0000-0000-0000-000000000000"
               onCellSelect={[Function]}
               rowHeaderIndex={0}
               rowHeight="2.5rem"
+              rowSelectionMode="multiple"
               rows={
                 Array [
                   Object {
@@ -6676,14 +6676,14 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                       },
                     ]
                   }
-                  hasRowSelection={true}
                   height="2.5rem"
                   id="1"
                   isTableStriped={true}
                   key="1"
                   onCellSelect={[Function]}
                   rowHeaderIndex={0}
                   rowIndex={2}
+                  rowSelectionMode="multiple"
                   tableId="test-terra-data-grid-table"
                 >
                   <tr
@@ -7188,14 +7188,14 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                       },
                     ]
                   }
-                  hasRowSelection={true}
                   height="2.5rem"
                   id="2"
                   isTableStriped={true}
                   key="2"
                   onCellSelect={[Function]}
                   rowHeaderIndex={0}
                   rowIndex={3}
+                  rowSelectionMode="multiple"
                   tableId="test-terra-data-grid-table"
                 >
                   <tr
@@ -7696,14 +7696,14 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                       },
                     ]
                   }
-                  hasRowSelection={true}
                   height="2.5rem"
                   id="3"
                   isTableStriped={true}
                   key="3"
                   onCellSelect={[Function]}
                   rowHeaderIndex={0}
                   rowIndex={4}
+                  rowSelectionMode="multiple"
                   tableId="test-terra-data-grid-table"
                 >
                   <tr
@@ -8203,7 +8203,6 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                       },
                     ]
                   }
-                  hasRowSelection={true}
                   height="2.5rem"
                   id="4"
                   isSelected={true}
@@ -8212,6 +8211,7 @@ exports[`DataGrid verifies row selection column header selection 1`] = `
                   onCellSelect={[Function]}
                   rowHeaderIndex={0}
                   rowIndex={5}
+                  rowSelectionMode="multiple"
                   tableId="test-terra-data-grid-table"
                 >
                   <tr
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,6 +2,9 @@ @@
     ## Unreleased
+    Changed
+      * Updated Table component to use new `rowSelectionMode` prop instead of `hasSelectableRows`.
     ## 1.2.0 - (November 20, 2023)
     * Fixed
@@ Expand Down @@