This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Tabs] Vertical Orientation for Tabs. #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 21, 2023 10:00
added 3 commits
October 6, 2023 11:03
added 2 commits
October 10, 2023 14:43
… UXAPPLPLAT-1122
added 2 commits
October 13, 2023 10:40
… UXAPPLPLAT-1122
… UXAPPLPLAT-1122
sdadn
reviewed
Oct 17, 2023
| /** | ||
| * By Default Orientation will be Horizontal and Orientation will be Vertical When verticalOrientation set to `true`. | ||
| */ | ||
| verticalOrientation: PropTypes.bool, |
There was a problem hiding this comment.
By verticalOrientation, do you mean vertical tabs?
supreethmr
reviewed
Oct 18, 2023
supreethmr
approved these changes
Oct 18, 2023
saket2403
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Vertical Tab is created by passing a prop "verticalOrientation".
Added Key to the commontabItem to make every child unique.
Removed ariaLabel prop as requried.
Why it was changed:
To add vertical orientation for the tabs.
Fix for unique keys warning.
Fix for missing ariaLabel prop warning.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9242
UXPLATFORM-9742
UXPLATFORM-9741
Post Implementation Screenshot
Thank you for contributing to Terra.
@cerner/terra