This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-data-grid] Flowsheet Data Grid - No Result Cell #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm9361
reviewed
Oct 11, 2023
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
aef2559 to
395e303
Compare
smason0
commented
Oct 11, 2023
cm9361
reviewed
Oct 12, 2023
cm9361
reviewed
Oct 12, 2023
cm9361
reviewed
Oct 12, 2023
cm9361
reviewed
Oct 12, 2023
cm9361
reviewed
Oct 12, 2023
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
441f72c to
81a1b26
Compare
cm9361
reviewed
Oct 13, 2023
cm9361
approved these changes
Oct 13, 2023
sdadn
approved these changes
Oct 13, 2023
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
e96fa4b to
d0ef42b
Compare
chrismichalewicz
added
⭐ Accessibility Reviewed
and removed
Accessibility Review Required
labels
eawww
reviewed
Oct 20, 2023
...-site/doc/data-grid/FlowsheetDataGrid.4/Examples.6/FlowsheetDataGridResultsMissing.2.doc.mdx
Show resolved
Hide resolved
...es/terra-framework-docs/src/terra-dev-site/doc/data-grid/FlowsheetDataGrid.4/About.5.doc.mdx
Outdated
Show resolved
Hide resolved
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
d081e49 to
832197d
Compare
eawww
approved these changes
Oct 23, 2023
...es/terra-framework-docs/src/terra-dev-site/doc/data-grid/FlowsheetDataGrid.4/About.5.doc.mdx
Outdated
Show resolved
Hide resolved
...-site/doc/data-grid/FlowsheetDataGrid.4/Examples.6/FlowsheetDataGridResultsMissing.2.doc.mdx
Outdated
Show resolved
Hide resolved
eawww
added
⭐ UX Reviewed
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
b3c8bdf to
3067971
Compare
smason0
force-pushed
the
UXPLATFORM-9405
branch
from
619ac5b to
f0b0b51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Added support for "No result" cells, displayed as "--" in the Flowsheet Data Grid.
Why it was changed:
This adds the proper visual indication for when a (non-header) Flowsheet cell has no results, and allows it to be read as "No result" by AT.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9405
Thank you for contributing to Terra.
@cerner/terra