Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-tabs] Fixed A11y issues #1833

Merged
merged 6 commits into from
Oct 19, 2023
Merged

[terra-tabs] Fixed A11y issues #1833

merged 6 commits into from
Oct 19, 2023

Conversation

saket2403
Copy link
Contributor

Summary

The following A11y issues were fixed in tabs:

  • Removed additional SR phrase announced for draggable tabs when focused.
  • Changed aria-label to aria-describedby for delete hint

What was changed:

  • Removed additional SR phrase announced for draggable tabs when focused.
  • Changed aria-label to aria-describedby for delete hint

Why it was changed:
Changes were made to fix a11y issues identified after discussion with UX.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@saket2403 saket2403 marked this pull request as ready for review October 12, 2023 11:48
@supreethmr
Copy link
Contributor

supreethmr commented Oct 18, 2023

@saket2403 Can you fix the build failure ..??

Copy link
Contributor

@supreethmr supreethmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with above comments addressed

@github-actions github-actions bot temporarily deployed to preview-pr-1833 October 19, 2023 05:23 Destroyed
@saket2403 saket2403 merged commit 78bb27d into main Oct 19, 2023
21 checks passed
@saket2403 saket2403 deleted the tabs-ux-a11y branch October 19, 2023 09:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants