Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Enhance screen reader support to announce column headers are interactable. #1836

Merged
merged 74 commits into from
Oct 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
4586b1b
Copy src from branch UXPLATFORM-9147
sycombs Sep 25, 2023
61e616e
Copy docs/tests from UXPLATFORM-9147 branch
sycombs Sep 25, 2023
41d5697
Copy changelog entry
sycombs Sep 25, 2023
f0c547b
Copy the Jest updates
sycombs Sep 25, 2023
d0e71e5
Add translations
sycombs Sep 25, 2023
f83a0d8
Merge remote-tracking branch 'origin/main' into wdg_column_resizing
sycombs Sep 25, 2023
d2c2959
role 'slider' changed to be null when slider is not active
adoroshk Sep 29, 2023
0cc9d6e
Merge branch 'main' into wdg_column_resizing
adoroshk Sep 29, 2023
6356750
aria-label and aria-valuetext adjusted, role reverted
adoroshk Sep 29, 2023
c64ad23
slider - divider interchangable roles
adoroshk Oct 2, 2023
0dad843
use isNavigationEnabled for role
adoroshk Oct 2, 2023
5568179
testing without aria-valuetext, aria-label only
adoroshk Oct 2, 2023
b727ebe
combined aria-label
adoroshk Oct 2, 2023
2a4ceeb
aria-label and aria-valuetext adjusted
adoroshk Oct 2, 2023
ff48e99
added cell-focus-trapped and resume-navigation texts
adoroshk Oct 2, 2023
1b15e28
enabling navigation after setting column header aria live message
adoroshk Oct 2, 2023
78b23ed
removed columnWidthAnnouncement from aria-label
adoroshk Oct 3, 2023
a4fd285
Merge branch 'main' into wdg_column_resizing
adoroshk Oct 3, 2023
835c69d
state variables for aria-label and aria-valuetext added
adoroshk Oct 3, 2023
bc74a4a
ariaLabel and ariaValueText switched to boolean
adoroshk Oct 3, 2023
e2d3d3b
aria-label assigned on focus and removed on Enter or onBlur
adoroshk Oct 3, 2023
4de9bae
revert table prop changes
sdadn Oct 5, 2023
c949b32
updated ColumnResizeHandle.scss
sdadn Oct 5, 2023
82615a0
removed tableheight
sdadn Oct 6, 2023
526698c
removed table height calculation
sdadn Oct 6, 2023
04a321e
reverted condition
sdadn Oct 6, 2023
010c3f9
revert colors
sdadn Oct 6, 2023
ca10df4
Removed space
sdadn Oct 6, 2023
9569340
linter fixes
sdadn Oct 6, 2023
52c788e
linter fixes
sdadn Oct 6, 2023
ce7f8ea
Merge branch 'main' into wdg_column_resizing
sdadn Oct 6, 2023
fb573e5
added column resize handle tests
sdadn Oct 9, 2023
bc4901e
column header cell updates
sdadn Oct 9, 2023
a3320ed
linter fixes
sdadn Oct 9, 2023
db90402
updated column header cell snapshots
sdadn Oct 11, 2023
d5c6ea0
updated snapshots
sdadn Oct 11, 2023
256a9f5
fix for role slider or no role at all
adoroshk Oct 11, 2023
e1b6ddf
Merge branch 'main' into wdg_column_resizing
adoroshk Oct 11, 2023
b28d215
added wdio tests
sdadn Oct 13, 2023
7f5cf5d
merged main into current branch
sdadn Oct 13, 2023
c4b58f1
fixed jest tests
sdadn Oct 13, 2023
955a02e
linter fixes
sdadn Oct 13, 2023
698d130
updated datagrid test
sdadn Oct 13, 2023
b634939
Merge branch 'main' into wdg_column_resizing
sdadn Oct 13, 2023
48a60cc
Apply suggestions from code review
sdadn Oct 16, 2023
e4be9b6
Update packages/terra-data-grid/src/subcomponents/ColumnResizeHandle.jsx
sdadn Oct 16, 2023
84f17e0
Changed to focus button in the column header
Oct 16, 2023
30e3985
Update for github actions. Will be reverted later
Oct 16, 2023
e5fd211
Merge branch 'main' into wdg_column_resizing
sdadn Oct 17, 2023
6e66593
updated datagrid
sdadn Oct 17, 2023
281cf72
Updated selector for tests
Oct 18, 2023
74fb315
fixed isResizeHandleActive not resetting
sdadn Oct 18, 2023
5868be5
working column resizing
sdadn Oct 18, 2023
cb29ed1
updated tests
sdadn Oct 19, 2023
58ba111
working tests
sdadn Oct 20, 2023
aac35bf
linter fixes
sdadn Oct 20, 2023
9340a4c
removed polyfill
sdadn Oct 20, 2023
b81bf75
updated snapshots
sdadn Oct 20, 2023
0fc61be
updated snapshots
sdadn Oct 20, 2023
7cd98b5
updated snapshots
sdadn Oct 20, 2023
f74b948
updated CHANGELOG
sdadn Oct 20, 2023
00353ed
linter fixes
sdadn Oct 20, 2023
670288f
Merge branch 'main' into wdg_column_resizing
sdadn Oct 20, 2023
e149d55
updates wdio snapshots
sdadn Oct 20, 2023
88581fc
Merge branch 'wdg_column_resizing' into UXPLATFORM-9611
Oct 23, 2023
a2e12e1
Changes to focus button for column header cell
Oct 23, 2023
96e9da9
Merge branch 'wdg_column_resizing' into UXPLATFORM-9611
Oct 23, 2023
7de1a76
Added tests and fixed console, build errors
Oct 23, 2023
0a74744
Merge branch 'wdg_column_resizing' into UXPLATFORM-9611
Oct 24, 2023
4fa2502
Updated WDIO screenshots for new resize handle styles
Oct 24, 2023
016ab65
Added Changelog for documentation update.
Oct 24, 2023
ad6ad83
Merge branch 'wdg_column_resizing' into UXPLATFORM-9611
brithom Oct 24, 2023
15bc0e1
fix snapshop
brithom Oct 24, 2023
fe7af39
Merge branch 'wdg_column_resizing' into UXPLATFORM-9611
brithom Oct 24, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
testing without aria-valuetext, aria-label only
adoroshk committed Oct 2, 2023
commit 5568179f44a670347b8e15eaa614640577f23eba
Original file line number Diff line number Diff line change
@@ -136,8 +136,8 @@ const ColumnResizeHandle = (props) => {
case KeyCode.KEY_SPACE:
case KeyCode.KEY_RETURN:
// Lock focus into component
resizeHandleRef.current.focus();
setNavigationEnabled(false);
resizeHandleRef.current.focus();
columnContext.setColumnHeaderAriaLiveMessage(intl.formatMessage({ id: 'Terra.worklist-data-grid.cell-focus-trapped' }));
event.stopPropagation();
event.preventDefault();
@@ -186,8 +186,8 @@ const ColumnResizeHandle = (props) => {
aria-valuemin={isActive ? minimumWidth : null}
aria-valuenow={isActive ? columnWidth : null}
aria-valuemax={isActive ? maximumWidth : null}
aria-label={isActive ? intl.formatMessage({ id: 'Terra.worklist-data-grid.resize-handle-template' }, { columnText }) : null}
aria-valuetext={isActive ? intl.formatMessage({ id: 'Terra.worklist-data-grid.resize-handle-value-text' }, { columnWidth }) : null}
aria-label={isActive ? intl.formatMessage({ id: 'Terra.worklist-data-grid.resize-handle-template' }, { columnText, columnWidth }) : null}
// aria-valuetext={isActive ? intl.formatMessage({ id: 'Terra.worklist-data-grid.resize-handle-value-text' }, { columnWidth }) : null}
onMouseDown={onMouseDown}
onMouseUp={onMouseUp}
onMouseEnter={fitToTable}
2 changes: 1 addition & 1 deletion packages/terra-data-grid/translations/en-US.json
Original file line number Diff line number Diff line change
@@ -16,6 +16,6 @@
"Terra.worklistDataGrid.row-selection-mode-disabled": "Row Selection Mode disabled",
"Terra.worklistDataGrid.all-rows-selected" : "All rows selected",
"Terra.worklistDataGrid.all-rows-unselected" : "No rows selected",
"Terra.worklist-data-grid.resize-handle-template": "Column resize handle for {columnText}. Press Enter to use.",
"Terra.worklist-data-grid.resize-handle-template": "Column resize handle for {columnText}. Press Enter to use. {columnWidth} pixels",
"Terra.worklist-data-grid.resize-handle-value-text": "{columnWidth} pixels"
}