You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 24, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What was changed:
The Terra Table component was updated to allow consumers to control the visibility of column headers in the table.
Why it was changed:
The change was made to maintain passivity with existing implementations that requires the column headers to be hidden such as the Stella Timeline.
Testing
This change was tested using:
WDIO
Jest
Visual testing (please attach a screenshot or recording)
Other (please describe below)
No tests are needed
Reviews
In addition to engineering reviews, this PR needs:
UX review
Accessibility review
Functional review
Additional Details
N/A
This PR resolves:
UXPLATFORM-9638
Thank you for contributing to Terra.
@cerner/terra
The reason will be displayed to describe this comment to others. Learn more.
This wasn't clear in the jira but for the Stella Timeline case where the headers need to be visually hidden, they still need to exist to give that context to screen readers. A screen reader won't know to associate the external timeline as the column headers.
It gets the header info now! Thanks Charles. One last thing is the header cells shouldn't have buttons since they can't be accessed by anyone without a screen reader.
It gets the header info now! Thanks Charles. One last thing is the header cells shouldn't have buttons since they can't be accessed by anyone without a screen reader.
Thank you for the feedback, @eawww. I need the logic from upcoming PRs to remove the button. I would not want to add that to this PR to prevent merge conflicts. What I can do is make the cell be 'not selectable'. This should give the desired behavior once the JIRAs in-flight are merged. Would that be acceptable?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eawww
added
⭐ UX Reviewed
Summary
What was changed:
The Terra Table component was updated to allow consumers to control the visibility of column headers in the table.
Why it was changed:
The change was made to maintain passivity with existing implementations that requires the column headers to be hidden such as the Stella Timeline.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9638
Thank you for contributing to Terra.
@cerner/terra