This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-data-grid] Removed columnHeaderHeight from default tests #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
reviewed
Oct 19, 2023
| @@ -2,6 +2,9 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Changed | |||
There was a problem hiding this comment.
Correct me if I am wrong, but I had an impression that for tests only changes (as they are not user-facing changes) we don't need a changelog entry
There was a problem hiding this comment.
Won't I get a failure from the danger checks? Do I remove and we ignore those?
adoroshk
reviewed
Oct 19, 2023
kenk2
approved these changes
Oct 19, 2023
adoroshk
approved these changes
Oct 19, 2023
sycombs
approved these changes
Oct 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Removed columnHeaderHeight from default test
Why it was changed:
The change was made because the default example should leverage required fields. The column header height is not a required field.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9739
Thank you for contributing to Terra.
@cerner/terra