Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-tabs]Tabs doc site issue fix #1846

Merged
merged 8 commits into from
Oct 24, 2023
Merged

[terra-tabs]Tabs doc site issue fix #1846

merged 8 commits into from
Oct 24, 2023

Conversation

ashishkumbhare116
Copy link
Contributor

@ashishkumbhare116 ashishkumbhare116 commented Oct 20, 2023

Summary

These are two issues got reported on the doc site -

  • Default Tabs - Parent (Container Width: 220px): After you expand the More drop down the options are being cut off

  • All of the "Icon Only Tabs" examples: When you attempt to navigate the tabs via arrow keys the focus jumps up to the main Icons Only example. Works as expected with Mouse click

What was changed:

Why it was changed:

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9758


Thank you for contributing to Terra.
@cerner/terra

@ashishkumbhare116 ashishkumbhare116 marked this pull request as ready for review October 20, 2023 08:00
@github-actions github-actions bot temporarily deployed to preview-pr-1846 October 24, 2023 06:28 Destroyed
@supreethmr supreethmr merged commit 7165cd3 into main Oct 24, 2023
@supreethmr supreethmr deleted the tabdoc_fixes branch October 24, 2023 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants