Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-tabs] Fixes screen reader response when tabs are closed. #1849

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

sugan2416
Copy link
Contributor

@sugan2416 sugan2416 commented Oct 20, 2023

Summary

What was changed:

Fixes response when tabs are closed.

Why it was changed:

Deleted/Closed tab was announced as "tab_name removed, selected....."

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9765

Updated response (Same with JAWS and VO)
Screenshot 2023-10-20 at 6 46 49 PM


Thank you for contributing to Terra.
@cerner/terra

@sugan2416 sugan2416 changed the title [terra-tabs] Fixes screen reader response when active tabs are closed. [terra-tabs] Fixes screen reader response when tabs are closed. Oct 20, 2023
@sugan2416 sugan2416 self-assigned this Oct 20, 2023
@ShettyAkarsh
Copy link
Contributor

@sugan2416 when we delete a active tab and if the focus goes to the next immediate active tab. once the SR reads the removed message does it calls out the active tab details ?

@sugan2416
Copy link
Contributor Author

@sugan2416 when we delete a active tab and if the focus goes to the next immediate active tab. once the SR reads the removed message does it calls out the active tab details ?

Yes it does. Same can be seen in the screenshot added. The focused tab in image is an active one

@github-actions github-actions bot temporarily deployed to preview-pr-1849 October 23, 2023 09:24 Destroyed
@supreethmr supreethmr merged commit 448cb0d into main Oct 23, 2023
21 checks passed
@supreethmr supreethmr deleted the tabs-del-fix branch October 23, 2023 10:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants