This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-table] Provide examples and tests for focusable elements in a table. #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Oct 23, 2023
sycombs
reviewed
Oct 23, 2023
| @@ -7,6 +7,7 @@ | |||
| * Added | |||
| * Added test to cover enabling zebra striping for the `terra-table` component. | |||
| * Added test for tab focus for scrollable tables for the `terra-table` component. | |||
| * Added examples and tests to cover the behavior of interactive elements within a table for `terra=table`. | |||
There was a problem hiding this comment.
nit: typo?
Suggested change
| * Added examples and tests to cover the behavior of interactive elements within a table for `terra=table`. | |
| * Added examples and tests to cover the behavior of interactive elements within a table for `terra-table`. |
| Terra.validates.element('table-focus-first-button', { columnResizeSelector: focusElementSelector }); | ||
| }); | ||
|
|
||
| it('validates that the proper grid element is selected when Tab is used to give initial focus to the grid', () => { |
There was a problem hiding this comment.
Can we update this to differentiate it from line 114?
sycombs
approved these changes
Oct 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The tests and examples for the Terra Table were updated so that consumers could see how interactive elements work in the table and proper test coverage existed.
Why it was changed:
The change was made to improve test coverage and provide consumers with example to answer recurring questions.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9767
Thank you for contributing to Terra.
@cerner/terra