This repository has been archived by the owner on May 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 72
[terra-data-grid] DataGrid consumes Table #1851
Merged
Merged
Changes from 53 commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
52751b0
Initial commit to make datagrid consume table.
kenk2 e87b17f
Merge remote-tracking branch 'origin' into data-grid-consumes-table
kenk2 23e8de1
Add Aria label in table examples.
kenk2 edbfae2
Fix scrolling behavior and error with column select callback not send…
kenk2 2e88843
Update jest tests to reflect datagrid consuming table.
kenk2 0faba58
[terra-table] Scrollable table focus (#1844)
cm9361 1beb0de
Release 20/10 (#1847)
saket2403 0008abc
Add striped props to FlowSheet, DataGrid and WorklistDataGrid compone…
kenk2 2b04f5a
Update snapshots for flowsheet tests.
kenk2 dba679a
Fix error with end key navigation. Update snapshots for datagrid comp…
kenk2 1a5de1f
Fix odd selection bug in WDG. Update snapshots.
kenk2 208f49c
Merge branch 'main' into data-grid-consumes-table
kenk2 2e99aa8
Fix snapshot test. Update variable call for column length check.
kenk2 f0e9a8a
Fix stale reference snapshots. Use real package version for terra-tab…
kenk2 f3d7380
Revert changes made to table. Revert implementation of focus manageme…
kenk2 a2e0897
Restore original snapshot references.
kenk2 39956c5
Merge remote-tracking branch 'origin' into data-grid-consumes-table
kenk2 8abd810
Revert changes made in terra table with pinned columns and export.
kenk2 81eb08d
Fix onFocus warning and mapper property. Fix Row styling to handle se…
kenk2 74c9843
Fix up jest tests, rename maper functions.
kenk2 a6e294d
Merge branch 'main' into data-grid-consumes-table
kenk2 5075558
Add note about fixing row stripe styling. Fix links in package.json f…
kenk2 f74684a
Update styling on row style. Update aria labels for table examples.
kenk2 f9f7448
Update package refs. Attempt to useImperativeHandle to reduce fragile…
kenk2 0710859
Fix merge conflicts.
kenk2 719cc3f
Merge branch 'main' into data-grid-consumes-table
kenk2 aaf0934
Begin integration of column resize code in table.
kenk2 1811a34
Fix merge conflicts.
kenk2 8c79534
Merge remote-tracking branch 'origin' into data-grid-consumes-table
kenk2 0b3536e
Integrate resize handle code in table.
kenk2 c3091c8
[terra-menu] - Fixed SR not announcing menu group name information. (…
PK106552 9e9bb33
Fix some linting errors.
kenk2 8010cc1
Remove prop types file.
kenk2 a6f758e
Fix issue with column selection.
kenk2 56620e3
Fix merge conflicts.
kenk2 364791a
Follow implementation from datagrid column header cell. Fix tab index…
kenk2 aea2d62
Update test suite for WDG and prevent key event when on grid context …
kenk2 09071dd
Update some subcomponent tests.
kenk2 cc6a31f
Fix INTL warning.
kenk2 4571c43
Fix up table tests and focus logic in column header cells.
kenk2 38f2272
Fix up flowsheet tests.
kenk2 9a1a26c
Fix up datagrid tests.
kenk2 dc85f2f
Fix up some WDG tests.
kenk2 2dcf56f
Merge remote-tracking branch 'origin' into data-grid-consumes-table
kenk2 76a3f86
Update lockfile. Add table props manually. USe ignore lint error for …
kenk2 2a0cf34
Directly pass in ref params from grid to table. Do not use forward re…
kenk2 df2906d
Update test files. Fix bug with managing row focus toggles in WDG. Re…
kenk2 2a6ac7b
Fix merge conflicts.
kenk2 4c91fb5
Use React context approach for managing grid focus.
kenk2 34a9990
Update screenshots for WDG and DG components.
kenk2 253b0be
Fix merge conflicts.
kenk2 3afdb70
Fix snapshots for flowsheet.
kenk2 d88d6ea
Update changelog for terra framework docs.
kenk2 c0e1e10
Address PR feedback. Do not use extra constant for tracking row selec…
kenk2 836168c
Memoize the provider value for grid context.
kenk2 8a6447c
Add explanation for complex tabindex setting in ColumnHeaderCell.
kenk2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you rebase with main? This code should already be present and not show up as a change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change was not made in datagrid (which still has this bug), so I had to fix it in this PR. We're going to consume from table from now on so the fix was needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to update the data grid logic. We won't be using it.