This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-table] Custom message for masked cells #1858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroshk
approved these changes
Oct 26, 2023
smason0
reviewed
Oct 26, 2023
| * Fixed the `terra-tabs` icon-only examples keyboard navigation issue. | ||
| * Fixed broken links in the Worklist Data Grid documentation in `terra-data-grid` component. | ||
| * Updated | ||
| * Updated `terra-table` example to show providing custom masked cell message label. |
There was a problem hiding this comment.
Do we also need to update the props documentation for the Cell component?
|
WIth the recent release, this needs to be updated with main. Can you update it and add the CHANGELOG entries to the updated unreleased section? |
chrismichalewicz
added
⭐ Functionally Reviewed
and removed
Functional Review Required
labels
|
Tested the Default Table example with Jaws +Edge. the Masked Data cell communicated "Age hidden" all other examples it communicated "maske data" Updating the Functially Reviewed label |
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The API was updated to allow consumers to specify a custom message for masked cells.
Why it was changed:
The change was made to meet the requirement that some consumers require the ability to have custom messages to explain why a cell is masked.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9212
Thank you for contributing to Terra.
@cerner/terra