[compact-interactive-list] Initial component setup #1861
Conversation
|
The terra-table changes are only for fixing broken links to the terra-framework repo in terra-table package.json, and I think they don't need a changelog entry, but correct me if I am wrong |
There was a problem hiding this comment.
There are a bunch of extra entries in this file but I'm wondering if we should use the files property instead of npmignore. Files works as a whitelist while npmignore works as a blacklist. It's easier to think of what files you want vs accounting for any potential files you don't want.
@sycombs thoughts?
There was a problem hiding this comment.
If we use the files property instead of .npmignore, we just need to be careful about making sure to include everything needed. With the @cerner/terra-pills issue some time back, we were inadvertently omitting the CHANGELOG from releases since CHANGELOGs aren't automatically included (for npm@9).
For now I think we can continue using .npmignore for this change at least. My only concern with switching to using files would be increasing bloat in package.json, but it's not a big concern.
There was a problem hiding this comment.
we will need them in the future, but you are right, no need to have then at that point. Removed: 4392403
There was a problem hiding this comment.
same as above, removed in 4392403
| /** | ||
| * Boolean indicating whether or not the table columns should be displayed. Setting the value to false will hide the columns, | ||
| * but the voice reader will use the column header values for a11y. | ||
| */ | ||
| hasColumnHeaders: PropTypes.bool, | ||
| }; |
There was a problem hiding this comment.
I edited the prop to default to false and edited description per that. Currently the plan is to not display the headers, but allow users to turn them on if they need them.
UPD: I realized we might want to take care of the column headers later in the development process, so I removed it for now in 862cf1d
There was a problem hiding this comment.
I guess we need the shapes. I edited them a bit though: 4392403
Co-authored-by: Saad Adnan <[email protected]>
Summary
This PR sets up the base terra-compact-interactive-list component to prepare for development.
These changes are based on the following PRs:
Testing
The initial WDIO and Jest test were set up, but they don't have actual tests yet and will be updated with added functionality.
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR is a part of:
UXPLATFORM-9557