Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Updated package-lock with main. #1862

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Updated package-lock with main. #1862

merged 1 commit into from
Oct 26, 2023

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Oct 26, 2023

Summary

This PR updates package-lock so that it is up to date with main.

Note: The build is failing due to an a sub dependency update (https://github.com/cerner/terra-framework/actions/runs/6659718947/job/18099412922?pr=1857). While we haven't been able to identify the dependency yet, we were able to to get it to work with this package-lock.json.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

The change was tested by running npm start to make sure that the project compiles and starts correctly.

CleanShot 2023-10-26 at 17 05 28

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Oct 26, 2023
@sdadn
Copy link
Contributor Author

sdadn commented Oct 26, 2023

Force merging as the npm install works and the subsequent steps are working.

CleanShot 2023-10-26 at 17 31 45

The failure is due to an outdated snapshot but that can be resolved in a separate PR as this is only updating package-lock.

@sdadn sdadn merged commit 4d76251 into main Oct 26, 2023
20 of 21 checks passed
@sdadn sdadn deleted the update-package-lock branch October 26, 2023 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants