Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Fix Snapshot in NPM CI #1863

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix Snapshot in NPM CI #1863

merged 1 commit into from
Oct 26, 2023

Conversation

kenk2
Copy link
Contributor

@kenk2 kenk2 commented Oct 26, 2023

Summary

What was changed:
Fix a snapshot test post NPM CI with package lock.

Why it was changed:
To be consistent after the adoption of NPM CI w/ package-lock.json, and to fix a 3rd party dependency issue.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-XXXX


Thank you for contributing to Terra.
@cerner/terra

@kenk2 kenk2 requested a review from a team October 26, 2023 22:44
@kenk2 kenk2 self-assigned this Oct 26, 2023
@kenk2 kenk2 marked this pull request as ready for review October 26, 2023 22:44
@github-actions github-actions bot temporarily deployed to preview-pr-1863 October 26, 2023 22:48 Destroyed
@kenk2 kenk2 merged commit c69fbb8 into main Oct 26, 2023
@kenk2 kenk2 deleted the npm-ci-snapshot-fix branch October 26, 2023 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants