This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-tabs] Fixed issue to prefer customDisplay over label #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…framework into tab-custom-display
sdadn
reviewed
Oct 31, 2023
packages/terra-framework-docs/src/terra-dev-site/test/tabs/Tabs/ClosableTab.test.jsx
Show resolved
Hide resolved
supreethmr
approved these changes
Nov 2, 2023
sugan2416
approved these changes
Nov 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The label prop should get preference over customDisplay prop. But after the common tabs changes, customDisplay was not passed on to the CommonTabItem.Hence the label prop was rendered in all scenarios.
What was changed:
Passed the customDisplay prop to the CommonTabItem.
Why it was changed:
CustomDisplay prop was not getting rendered. Instead the label prop was getting preference.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9796
Thank you for contributing to Terra.
@cerner/terra