This repository has been archived by the owner on May 24, 2024. It is now read-only.
Table column header tab index fix #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenk2
approved these changes
Nov 9, 2023
| } | ||
|
|
||
| // Determine if button element is required for column header | ||
| const hasButtonElement = isSelectable && displayName; |
There was a problem hiding this comment.
non-blocking nit: Since we're making this change, we could probably declare this before the if statement on line 260.
There was a problem hiding this comment.
I put it here so that the buttonTabIndex logic would be together in one block of code.
eawww
approved these changes
Nov 9, 2023
sdadn
approved these changes
Nov 13, 2023
sdadn
suggested changes
Nov 13, 2023
packages/terra-table/CHANGELOG.md
Outdated
| @@ -11,6 +11,7 @@ | |||
| * Fixed issue where column header cell was receiving tab focus instead of the button for table role. | |||
| * Fixed column header left border style. | |||
| * Fixed resize handle being communicated when non-header cell is focused. | |||
| * Fixed tab index issues in the column header cells. | |||
There was a problem hiding this comment.
I believe this is in the wrong section after Friday's release
sdadn
approved these changes
Nov 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The Terra Table was updated such that the column headers will have a tab index on the button, if it exists, or else the table cell element. Previously, the table cell for a grid context always had a tab index of -1. The DataGrid component was also updated to properly account for this change.
Why it was changed:
The change was made because the cell having a tab index of -1 when a button was present caused the screen reader to read both element values. This change resolved the accessibility issue.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9804
Thank you for contributing to Terra.
@cerner/terra