This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-table] Fixed screenreader issue due to space in headers attribute #1889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smason0
approved these changes
Nov 15, 2023
sdadn
approved these changes
Nov 15, 2023
eawww
approved these changes
Nov 15, 2023
|
@cm9361 - I validated many if the examples with Edge/JAWS and the headers were announced correctly. However, JAWS is no longer announcing the number of columns and rows. We need that functionality to be preserved. |
mjpalazzo
added
⭐ Accessibility Reviewed
and removed
Accessibility Review Required
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
The unnecessary spaces were removed from the headers attribute in the table cells.
Why it was changed:
The spaces caused unexpected issues with the JAWS screenreader.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9862
Thank you for contributing to Terra.
@cerner/terra