-
Notifications
You must be signed in to change notification settings - Fork 72
[terra-table] Provide screenreader value for row selection column header #1892
Conversation
@cm9361 I did the following validation with Edge/JAWS. I have a question for the row selection example: |
Thank you for pointing out these issues. There must have been a breaking change at some point. We would need to resolve the issue in another PR. Could you please log a JIRA? |
/** | ||
* Boolean value indicating whether or not the header cell is focused. | ||
*/ | ||
isDisplayVisible: PropTypes.bool, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the prop description correct? It seems like the value is used to show/hide the display text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I made a mistake here. Ugh!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about the prop description but code wise it looks good so approving it.
Summary
What was changed:
The Table component was updated such that a screenreader value was associated with the row selection column header. The component was also updated to properly read the header text and error indicator in the proper order. It now also properly reads the sort indicator and associated direction changes on all screenreaders.
Why it was changed:
The change was made to improve the accessibility of the Table component.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
N/A
This PR resolves:
UXPLATFORM-9867
UXPLATFORM-9865
UXPLATFORM-9685
Thank you for contributing to Terra.
@cerner/terra