Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-data-grid] FlowsheetDataGrid - Remove unsupported props from docs #1897

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

smason0
Copy link
Contributor

@smason0 smason0 commented Nov 17, 2023

Summary

What was changed:
FlowsheetDataGrid API docs were updated to remove isSelectable from both Column and Cell, and isMasked from Cell. All columns and cells in FlowsheetDataGrid now set this prop in the underlying component to always be true.

Why it was changed:
Flowsheet should not allow columns and cells to be unselectable or masked. These concepts are needed by the sibling component WorklistDataGrid, but should not be included as configurable options for flowsheet.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9882


Thank you for contributing to Terra.
@cerner/terra

@cm9361
Copy link
Contributor

cm9361 commented Nov 17, 2023

I understand the change for isSelectable. I am curious if there is never a use case for masked cells in the flowsheet. I also don't see the harm in it being available. If this is a hard requirement, should we also have logic to set isMasked to false for every cell similar to the logic you added for isSelectable?

@smason0
Copy link
Contributor Author

smason0 commented Nov 17, 2023

I understand the change for isSelectable. I am curious if there is never a use case for masked cells in the flowsheet. I also don't see the harm in it being available. If this is a hard requirement, should we also have logic to set isMasked to false for every cell similar to the logic you added for isSelectable?

It is a requirement of Flowsheet, and isMasked sets a cell to be unselectable. The reason I don't set isMasked to false for every cell is because it is falsy by default, unlike isSelectable which must be true to make a cell or column header selectable.

@smason0 smason0 closed this Nov 17, 2023
@smason0 smason0 reopened this Nov 17, 2023
@github-actions github-actions bot temporarily deployed to preview-pr-1897 November 17, 2023 17:39 Destroyed
@nikhitasharma nikhitasharma merged commit 7c8a802 into main Nov 17, 2023
43 checks passed
@nikhitasharma nikhitasharma deleted the UXPLATFORM-9882 branch November 17, 2023 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants