-
Notifications
You must be signed in to change notification settings - Fork 72
[terra-data-grid] Flowsheet Data Grid - Row Selection #1907
Conversation
@smason0 - Overall the Flowsheet row selection example works well, but I observed one issue when testing with Edge/JAWS. I used the Down Arrow key to navigate to a row and pressed Space to select the row. JAWS announced, "Space, Row 2 selected" as expected. I pressed Down Arrow to navigate to row 3. AWS announced, "Space, Row 3 selected, row 1 unselected" JAWS announced the wrong index for the unselected row. I tested with Safari/VO as well and observed the same issue. |
765598b
to
0c20917
Compare
@mjpalazzo this sounds like what was fixed by #1906 . Should be good once those changes make it into this branch. |
@mjpalazzo As @eawww said, that might have been because I was on an older revision of main. I have now pulled in the fix #1906 into the base of my branch. |
0c20917
to
1c20dbc
Compare
This will require the same a11y work detailed for table single select but it works correctly aside from that. |
1c20dbc
to
242a551
Compare
242a551
to
93aa914
Compare
During testing of the most recent deployment, we've confirmed the described issue is now fixed. |
Summary
What was changed:
Added new prop
onRowSelect
to FlowsheetDataGrid. This allows consumers to add behavior for when a cell in the row header column is selected. An example has also been added to the docs.Why it was changed:
This change is needed to remain passive with the flowsheet functionality expected by some consumers. The example of using the
onRowSelect
callback gives consumers a reference to use when implementing their own callback function.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9735
Thank you for contributing to Terra.
@cerner/terra