Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-data-grid] Flowsheet Data Grid - Row Selection #1907

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

smason0
Copy link
Contributor

@smason0 smason0 commented Nov 20, 2023

Summary

What was changed:
Added new prop onRowSelect to FlowsheetDataGrid. This allows consumers to add behavior for when a cell in the row header column is selected. An example has also been added to the docs.

Why it was changed:
This change is needed to remain passive with the flowsheet functionality expected by some consumers. The example of using the onRowSelect callback gives consumers a reference to use when implementing their own callback function.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9735


Thank you for contributing to Terra.
@cerner/terra

@mjpalazzo
Copy link
Contributor

@smason0 - Overall the Flowsheet row selection example works well, but I observed one issue when testing with Edge/JAWS. I used the Down Arrow key to navigate to a row and pressed Space to select the row. JAWS announced, "Space, Row 2 selected" as expected. I pressed Down Arrow to navigate to row 3. AWS announced, "Space, Row 3 selected, row 1 unselected" JAWS announced the wrong index for the unselected row. I tested with Safari/VO as well and observed the same issue.

@eawww
Copy link
Contributor

eawww commented Nov 20, 2023

@mjpalazzo this sounds like what was fixed by #1906 . Should be good once those changes make it into this branch.

@smason0
Copy link
Contributor Author

smason0 commented Nov 20, 2023

@mjpalazzo As @eawww said, that might have been because I was on an older revision of main. I have now pulled in the fix #1906 into the base of my branch.

@eawww
Copy link
Contributor

eawww commented Nov 21, 2023

This will require the same a11y work detailed for table single select but it works correctly aside from that.

@github-actions github-actions bot temporarily deployed to preview-pr-1907 November 22, 2023 13:54 Destroyed
@smason0
Copy link
Contributor Author

smason0 commented Nov 22, 2023

@smason0 - Overall the Flowsheet row selection example works well, but I observed one issue when testing with Edge/JAWS. I used the Down Arrow key to navigate to a row and pressed Space to select the row. JAWS announced, "Space, Row 2 selected" as expected. I pressed Down Arrow to navigate to row 3. AWS announced, "Space, Row 3 selected, row 1 unselected" JAWS announced the wrong index for the unselected row. I tested with Safari/VO as well and observed the same issue.

During testing of the most recent deployment, we've confirmed the described issue is now fixed.

@cm9361 cm9361 merged commit 6af7863 into main Nov 22, 2023
21 checks passed
@cm9361 cm9361 deleted the UXPLATFORM-9735-2 branch November 22, 2023 18:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants