This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-time-input] Added visual label and status message to announce invalid input #1942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadanKumarGovindaswamy
changed the title
supreethmr
reviewed
Dec 15, 2023
supreethmr
approved these changes
Dec 15, 2023
Co-authored-by: Supreeth <[email protected]>
sugan2416
reviewed
Dec 18, 2023
There was a problem hiding this comment.
Why are there screenshot updates in date-time-picker ?
There was a problem hiding this comment.
Build was getting failed because of WDIO mismatch error. I guess scroll container position got updated. Thanks
sugan2416
approved these changes
Dec 18, 2023
Please provide appropriate input label for all the example. Not looking good for now.
|
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Added status message to announce invalid input.
Added visual label to first example
Why it was changed:
Terra Time Input does not provide any indication of letter not being accepted or on certain occasions does not convey to the user their entry was not accepted.
Terra Time Input does not provide any visual label.
Invalid.response.mov
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10041
Thank you for contributing to Terra.
@cerner/terra