This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-collapsible-menu-view] Flicker issue when wrapped with clinical header #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadanKumarGovindaswamy
changed the title
supreethmr
reviewed
Jan 9, 2024
| ); | ||
| }; | ||
|
|
||
| export default FilePathwithClinicalHeader; |
There was a problem hiding this comment.
Suggested change
| export default FilePathwithClinicalHeader; | |
| export default FilePathwithActionHeader; |
can we get the filename also updated to action header
There was a problem hiding this comment.
Updated.
Commit: a09f4db
Thanks
supreethmr
approved these changes
Jan 9, 2024
supreethmr
reviewed
Jan 9, 2024
| } | ||
| // to calculate available space when resized only when menuButtonContainerWidth is used | ||
| if ((window.innerWidth - menuButtonWidth) < availableWidth) { | ||
| availableWidth = window.innerWidth - menuButtonWidth; |
There was a problem hiding this comment.
will this be having -ve value ..?? I think we can use Math.Abs() if we are not sure edge case where it could be -ve
There was a problem hiding this comment.
Added Math.abs to avoid -ve values.
c66f453
Thanks
saket2403
approved these changes
Jan 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Updated to calculate the available space from the collapsible menu container div when collapsible menu view component is wrapped with clinical header component.
Why it was changed:
When a file path with a small label is added dynamically inside a clinical header it starts to flicker.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
Screen.Recording.2024-01-09.at.11.01.39.AM.mov
This PR resolves:
UXPLATFORM-10099
Thank you for contributing to Terra.
@cerner/terra