This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-folder-tree] Added tabIndex for only last focused item #1967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycombs
reviewed
Jan 5, 2024
| Terra.validates.screenshot('tabbed out of focus', { selector: '#root' }); | ||
|
|
||
| browser.keys(['Shift', 'Tab']); | ||
| Terra.validates.screenshot('level two folder focused keyboard', { selector: '#expand-collapse-folder-tree' }); |
There was a problem hiding this comment.
I like that we're avoiding adding extra screenshots here, just wondering if there are any potential issues with validating the same screenshot twice in this test.
There was a problem hiding this comment.
I've done this in the past before, and both screenshots should result in the same identical image, so I believe it should be alright
There was a problem hiding this comment.
Is there a need to validate teh same screenshot twice? If we're only checking for focus, we can use the isFocused() validator since that's more efficient than doing a screenshot comparison.
There was a problem hiding this comment.
Oh that's right! I keep forgetting we have that, I'll update it to use that
sdadn
approved these changes
Jan 5, 2024
eawww
approved these changes
Jan 5, 2024
eawww
added
⭐ UX Reviewed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
All folder tree children no longer has a tabIndex of 0. When moving through the elements with the arrow keys, the currently focused item is the only item with a tabIndex of 0.
Why it was changed:
Tabbing in and out of the component will not make the user tab through all the items to get to the intended item.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10109
Thank you for contributing to Terra.
@cerner/terra