This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-theme-provider] Import terra-theme-properties package #1979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sycombs
commented
Jan 12, 2024
| @@ -28,7 +28,8 @@ | |||
| "dependencies": { | |||
| "classnames": "^2.2.5", | |||
| "prop-types": "^15.5.8", | |||
| "terra-mixins": "^1.0.0" | |||
| "terra-mixins": "^1.0.0", | |||
| "terra-theme-properties": "file:../../terra-theme-properties-0.1.0.tgz" | |||
There was a problem hiding this comment.
This will be updated to use the released version of terra-theme-properties once it is available.
sycombs
commented
Jan 12, 2024
terra-theme-properties-0.1.0.tgz
Outdated
There was a problem hiding this comment.
This will be removed once using the released version of terra-theme-properties.
adoroshk
approved these changes
Jan 16, 2024
cm9361
approved these changes
Jan 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consumes and imports the
terra-theme-propertiespackage intoterra-theme-provider, so that Terra Redwood theme variables are available viaterra-theme-provider.Testing
This change was tested using:
Tested by adding
redwood-themetoterra-theme.config.jsand running the local server vianpm start. The theme variables are available in the dev tools:Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-9932
Thank you for contributing to Terra.
@cerner/terra