This repository has been archived by the owner on May 24, 2024. It is now read-only.
[date-time-picker] Update Screen reader response not to read visually hidden text with name attribute. #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MadanKumarGovindaswamy
changed the title
supreethmr
reviewed
Jan 17, 2024
| @@ -229,7 +229,6 @@ const DatePickerInput = (props) => { | |||
|
|
|||
| const additionalInputProps = { ...customProps, ...inputAttributes }; | |||
| const momentDateFormat = useMemo(() => DateUtil.getFormatByLocale(intl.locale), [intl.locale]); | |||
| const nameLabelId = `name-label-${uuidv4()}`; | |||
There was a problem hiding this comment.
This Id was created to fix the issue of label not being announced by screen reader, Does this PR still ensures label announcement by screen readers..?
There was a problem hiding this comment.
This Id was tagged to name attribute. And even earlier visual label is announced by the screen reader. Ashish has created a PR for the label announcement.
supreethmr
approved these changes
Jan 19, 2024
|
+1 |
MadanKumarGovindaswamy
added
⭐ Accessibility Reviewed
and removed
Accessibility Review Required
labels
saket2403
approved these changes
Jan 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Update Screen reader response not to read visually hidden text with name attribute.
Why it was changed:
When user first navigates to the date input field, then the visually hidden text with name attribute is exposed to user which is not contextual and can be confusing.
Screen.Recording.2024-01-17.at.5.13.06.PM.mov
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10137
Thank you for contributing to Terra.
@cerner/terra