Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

[terra-compact-interactive-list] Fixed MPages page level error on cell select #2002

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

saket2403
Copy link
Contributor

Summary

Fixed MPages page level error on cell select

What was changed:

Spread the array when creating a new one.

Why it was changed:
Earlier implementation causing page level error in MPages.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10173


Thank you for contributing to Terra.
@cerner/terra

@saket2403 saket2403 self-assigned this Jan 25, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-2002 January 25, 2024 07:58 Destroyed
@saket2403 saket2403 requested review from ShettyAkarsh and sdadn and removed request for akarsh1888 January 25, 2024 08:05
@saket2403 saket2403 merged commit 3f771cf into main Jan 25, 2024
22 checks passed
@saket2403 saket2403 deleted the comp-list-bug branch January 25, 2024 14:21
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I was in progress and checked that it worked. I'll make an additional PR to add unit tests covering that change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants