This repository has been archived by the owner on May 24, 2024. It is now read-only.
[Terra-Date-Time-Picker] - Added visual focus dashed border and SR fix #2035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 16, 2024 11:26
saket2403
approved these changes
Feb 21, 2024
sugan2416
reviewed
Feb 21, 2024
| * If invalid error text is used, provide a string containing the IDs for error html element. | ||
| * ID must be htmlFor prop value with error text. | ||
| */ | ||
| ariaDescribedBy: PropTypes.string, |
There was a problem hiding this comment.
Rename prop to something meaningful related to error message id. Since this prop was mainly introduced to announce error message. Add a11y label wherever this prop is defined.
sugan2416
reviewed
Feb 21, 2024
| @@ -861,7 +869,7 @@ const DatePickerInput = (props) => { | |||
| onBlur={onBlur} | |||
| onFocus={onButtonFocus} | |||
| refCallback={buttonRefCallback} | |||
| aria-label={`${calendarDate} ${intl.formatMessage({ id: 'Terra.datePicker.openCalendar' })}`} | |||
There was a problem hiding this comment.
If this is removed, then SR will not announce the date selected from calendar popup upon closure. This needs to discussed with a11y team. This date is to provide date context due to instant closing of calendar.
sugan2416
approved these changes
Feb 21, 2024
|
Hi rahul, Reverted selected announcement fixes and created new JIRA for that - https://jira2.cerner.com/browse/UXPLATFORM-10245 |
|
+1 for the a11y changes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
terra-date-time-pickerexample for invalid error message announcement.Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra