This repository has been archived by the owner on May 24, 2024. It is now read-only.
[terra-menu] Update MenuItemGroup to retain state when isToggled prop is used #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhitasharma
changed the title
sdadn
approved these changes
Feb 23, 2024
sycombs
reviewed
Feb 23, 2024
packages/terra-framework-docs/src/terra-dev-site/test/menu/menu/SelectableMenu.test.jsx
Outdated
Show resolved
Hide resolved
nikhitasharma
force-pushed
the
retain-terra-menu-state
branch
from
b5adada to
4d95a57
Compare
sycombs
approved these changes
Feb 26, 2024
|
The WDIO failures are not related to this change. |
chrismichalewicz
added
⭐ Functionally Reviewed
and removed
Functional Review Required
Functional Review Ready
labels
|
@nikhitasharma This has been functionally reviewed. Looks good! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
isToggledprop is used.Why it was changed:
The Terra-Menu component needs to be updated to retaining selected state for single select menu after the menu is closed and re-opened. Currently, the single select examples and tests which use
isToggledprop do not retain selected state because of a missing condition and only usingisSelectedprop works .Note:
Since Menu docs show that
isSelectedprop will soon be deprecated, we need to make this change to retain selection state usingisToggledas well.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10186
Thank you for contributing to Terra.
@cerner/terra