[terra-date-time-picker] - Fixed error reading issue in time input #2050
Conversation
|
Can you add a jest test to validate the change |
| @@ -1092,7 +1092,7 @@ class TimeInput extends React.Component { | |||
| size="2" | |||
| pattern="\d*" | |||
| description={`${hourDescription()}, ${hotKeyDescription}`} | |||
| errorId={errorId} | |||
| ariaDescribedBy={errorId} | |||
There was a problem hiding this comment.
You can instead rename ariaDescribedBy prop in accessibleInput to errorId to keep it consistent. Since the description of that prop suggests its only used for err message announcement.
There was a problem hiding this comment.
Already i have updated to errorID in date picker and date time picker, but already kadali has added ariaDescribedBy prop in AccessibleInput component to read error message for date input(https://github.com/cerner/terra-framework/pull/1975/files#diff-f42c6c0190bcd6e255f09217576b27f9f78c66c4a407ea440f434bcfa0efb614R30).
Note : Still consumer should pass error id via errorId props only.
Updated |
|
+1 for Accessibility review, the error message is exposed as expected for both Date and Time Input field. |
PK106552
added
⭐ Accessibility Reviewed
and removed
Accessibility Review Required
labels
Summary
What was changed:
Why it was changed:
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra