Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Added the change for props change rerender Issue #2052

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

ashishkumbhare116
Copy link
Contributor

@ashishkumbhare116 ashishkumbhare116 commented Feb 27, 2024

Summary

What was changed:

  • Fixed State is not re-rendering when we update icon prop.

Why it was changed:

  • Re-render was not happening when we update icon prop.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10244


Thank you for contributing to Terra.
@cerner/terra

@PK106552 PK106552 marked this pull request as ready for review March 8, 2024 10:41
@github-actions github-actions bot temporarily deployed to preview-pr-2052 March 8, 2024 10:41 Destroyed
@@ -2,6 +2,9 @@

## Unreleased

* Changed
* Added the fix for changing the props not rerendering component.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Added the fix for changing the props not rerendering component.
* Fixes component re-render with updated icon.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@@ -2,6 +2,9 @@

## Unreleased

* Changed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Changed
* Fixed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@PK106552 PK106552 force-pushed the terraTabsPropsChangeFix branch from 86a6fb6 to 2bd5898 Compare March 8, 2024 12:16
@github-actions github-actions bot temporarily deployed to preview-pr-2052 March 8, 2024 12:16 Destroyed
@PK106552 PK106552 force-pushed the terraTabsPropsChangeFix branch from 7f7978c to db464ae Compare March 8, 2024 12:17
@github-actions github-actions bot temporarily deployed to preview-pr-2052 March 8, 2024 12:22 Destroyed
@sugan2416 sugan2416 merged commit 6ca3e3a into main Mar 8, 2024
22 checks passed
@sugan2416 sugan2416 deleted the terraTabsPropsChangeFix branch March 8, 2024 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants